Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: use pytest.raises context manager (io.sql) #25597

Merged
merged 3 commits into from
Mar 9, 2019
Merged

STY: use pytest.raises context manager (io.sql) #25597

merged 3 commits into from
Mar 9, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #24332

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite IO SQL to_sql, read_sql, read_sql_query labels Mar 7, 2019
@codecov
Copy link

codecov bot commented Mar 7, 2019 •
edited
Loading

Codecov Report

Merging #25597 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25597   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52966    52966           
=======================================
  Hits        48338    48338           
  Misses       4628     4628
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72e7ed...a3d342b. Read the comment docs.

simonjayhawkins
simonjayhawkins commented Mar 7, 2019
View reviewed changes
pandas/tests/io/test_sql.py
con=self.conn,
name=table_name,
if_exists='notvalidvalue')
with pytest.raises(ValueError, match="<insert message here>"):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dummy message for unconditionally skipped test. xref #20536

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that makes sense.

@simonjayhawkins simonjayhawkins changed the title [WIP] STY: use pytest.raises context manager (io.sql) STY: use pytest.raises context manager (io.sql) Mar 7, 2019
gfyoung
gfyoung approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jreback

@jreback jreback added this to the 0.25.0 milestone Mar 9, 2019
@jreback jreback merged commit 976a2db into pandas-dev:master Mar 9, 2019
@jreback
Copy link
Contributor

jreback commented Mar 9, 2019

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the cm-sql branch March 10, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@simonjayhawkins @jreback @WillAyd @gfyoung